Skip to content

fix: relative paths in the project #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BekahHW merged 26 commits into from
Apr 18, 2024
Merged

fix: relative paths in the project #162

BekahHW merged 26 commits into from
Apr 18, 2024

Conversation

@adiati98
Copy link
Collaborator

@adiati98 adiati98 commented Apr 18, 2024 •
edited
Loading

Description

This PR mainly fixes the relative paths that lead to 404 in GitHub. They're still working as intended on the website.

Along the fixes, this PR also holds the following changes:

  • Added relative paths to the "next chapter" term in the last paragraph of each chapter for better navigation on GitHub. In the case of no last paragraph, I added a sentence for navigation.
  • Added relative paths to the chapter titles on README (for consistency with the future Maintainers course) and intro.md.
  • Restructured the sidebar by moving the "Conclusion" chapter to before "Additional Resouces" for better flow.

Note

@BekahHW I've tested the relative paths on a private repo and they work well.

Related Tickets & Documents

Fixes #161

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

adiati98 added 25 commits April 18, 2024 09:41
@adiati98
fix: relative paths in the homepage README
af7f478
@adiati98
feat: add intro chapter to the course overview section in the intro c…
273a878 
…ourse README
@adiati98
fix: update title
f2afd83
@adiati98
fix: add and fix relative paths in intro course README
9198c5c
@adiati98
fix(intro.md): update course structure section and add relative paths
bb90d1c
@adiati98
fix(intro.md): add relative path to next chapter
0e4d32f
@adiati98
fix(what-is-open-source.md): add relative path to next chapter
ca4d019
@adiati98
fix(why-open-source.md): remove codesee
f12e68d
@adiati98
fix(why-open-source.md): add relative path to next chapter
7d7d943
@adiati98
fix(tools-to-be-successful.md): add relative path to next chapter
c05181e
@adiati98
fix(how-to-contribute-to-open-source.md): wording in the note
63db393
@adiati98
fix(how-to-contribute-to-open-source.md): add relative path to next c…
869fb2c 
…hapter
@adiati98
fix(the-secret-sauce.md): add a sentence to navigate to the next chapter
d05ac28
@adiati98
fix(types-of-contributions): add a sentence to navigate to the next c…
1fe2927 
…hapter
@adiati98
fix(conclusion.md): capitalization, update wording and add relative p…
6812586 
…aths
@adiati98
fix(CONTRIBUTING.md): capitalization and relative paths
0c52b4a
@adiati98
fix(i18n-guidelines.md): relative paths
ccc207f
@adiati98
fix(_sidebar.md): move conclusion link for better flow
f25d553
@adiati98
fix(README.md): relative paths in French translation
6e1373f
@adiati98
fix(CONTRIBUTING.md): docsify capitalization and relative paths in Fr…
f0f8c9a 
…ench translation
@adiati98
fix(comment-contribuer-à-l-open-source.md): relative paths
2c37a0f
@adiati98
fix(conclusion.md): relative paths in French translation
8ef29a7
@adiati98
fix(pourquoi-open-source.md): remove codesee
70cb12e
@adiati98
fix(ressources-additionnelles.md): spacing
6b5a253
@adiati98
fix(_sidebar.md): structure French sidebar to reflect English version
85a33b2
@adiati98 adiati98 added the documentation Improvements or additions to documentation label Apr 18, 2024
@adiati98 adiati98 self-assigned this Apr 18, 2024
@adiati98 adiati98 requested a review from a team as a code owner April 18, 2024 09:37
@netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for sauced-intro ready!

Name Link
🔨 Latest commit 0273b7e
🔍 Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/6620efb54774fa000815ce5c
😎 Deploy Preview https://deploy-preview-162--sauced-intro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BekahHW BekahHW merged commit 48e5f10 into main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BekahHW BekahHW BekahHW approved these changes

Assignees

@adiati98 adiati98

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Relative paths in the course redirected to 404

2 participants

@adiati98 @BekahHW