Skip to content

JacksonEncoder avoids intermediate String request body - #989

Merged
velo merged 2 commits into
OpenFeign:masterfrom
schlosna:ds/jackson-encoder
Jun 24, 2019
Merged

velo merged 2 commits into
OpenFeign:masterfrom
schlosna:ds/jackson-encoder

Conversation

@schlosna

Copy link
Copy Markdown
Contributor

Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation.

See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway

schlosna added a commit to schlosna/http-remoting that referenced this pull request Jun 18, 2019
Serialize Jackson request object directly to UTF-8 byte array without
intermediate String representation.

Introduces local Jackson encoder until
OpenFeign/feign#989 is upstreamed.

See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway
bulldozer-bot Bot pushed a commit to palantir/conjure-java-runtime that referenced this pull request Jun 18, 2019
…#1131)

Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation.

Introduces local Jackson encoder until OpenFeign/feign#989 is upstreamed.

See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway

@kdavisk6 kdavisk6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlosna

Thank you for this PR. I have one, very small suggestion.

@kdavisk6 kdavisk6 added enhancement For recommending new capabilities feedback provided Feedback has been provided to the author labels Jun 18, 2019
@schlosna

Copy link
Copy Markdown
Contributor Author

Thanks for the review @kdavisk6 . I've updated the PR with your suggestion.

@kdavisk6 kdavisk6 added this to the 10.3.0 milestone Jun 21, 2019
@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author labels Jun 21, 2019
@kdavisk6

Copy link
Copy Markdown
Member

@schlosna

I've marked this PR as ready to merge. If there are no additional comments in the next few days, this PR will be merged and is attached to our 10.3.0 Release.

@schlosna

Copy link
Copy Markdown
Contributor Author

Excellent, thank you!

@velo
velo merged commit 2a8ee35 into OpenFeign:master Jun 24, 2019
@schlosna
schlosna deleted the ds/jackson-encoder branch June 25, 2019 00:49
@kdavisk6 kdavisk6 modified the milestones: 10.3.0, 10.2.4 Jul 18, 2019
velo pushed a commit that referenced this pull request Oct 7, 2024
* JacksonEncoder avoids intermediate String request body

Serialize Jackson request object directly to UTF-8 byte array without
intermediate String representation.

See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway

* Use Util.UTF_8
velo pushed a commit that referenced this pull request Oct 8, 2024
* JacksonEncoder avoids intermediate String request body

Serialize Jackson request object directly to UTF-8 byte array without
intermediate String representation.

See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway

* Use Util.UTF_8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants