Repository navigation
Updated Expression Patterns to allow brackets - #939
Merged
kdavisk6 merged 2 commits intoApr 28, 2019
Merged
Conversation
Fixes OpenFeign#928 Relaxed the regular expression that is used to determine if a given value is an Expression per the URI Template Spec RFC 6570. We already deviated by allowing dashes to exist without pct-encoding, this change adds braces `[]` to this list. Also included is the ability to set Collection Format per Query, overriding the Template default. This allows for mixed Collection formats in the same template and provides a way for Contract extensions to determine which expansion type they want when parsing a contract.
OlgaMaciaszek
approved these changes
Apr 26, 2019
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Looks good, have tested on the example that caused the issue and it works well with this change.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Updated Expression Patterns to allow brackets Fixes #928 Relaxed the regular expression that is used to determine if a given value is an Expression per the URI Template Spec RFC 6570. We already deviated by allowing dashes to exist without pct-encoding, this change adds braces `[]` to this list. Also included is the ability to set Collection Format per Query, overriding the Template default. This allows for mixed Collection formats in the same template and provides a way for Contract extensions to determine which expansion type they want when parsing a contract. * Fixing Formatting
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Updated Expression Patterns to allow brackets Fixes #928 Relaxed the regular expression that is used to determine if a given value is an Expression per the URI Template Spec RFC 6570. We already deviated by allowing dashes to exist without pct-encoding, this change adds braces `[]` to this list. Also included is the ability to set Collection Format per Query, overriding the Template default. This allows for mixed Collection formats in the same template and provides a way for Contract extensions to determine which expansion type they want when parsing a contract. * Fixing Formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
Relaxed the regular expression that is used to determine if a given
value is an Expression per the URI Template Spec RFC 6570. We already
deviated by allowing dashes to exist without pct-encoding, this change
adds braces
[]to this list.Also included is the ability to set Collection Format per Query, overriding
the Template default. This allows for mixed Collection formats in the
same template and provides a way for Contract extensions to determine
which expansion type they want when parsing a contract.