Repository navigation
Replaced comma with Constant Delimiter in Template - #930
Conversation
Fixes OpenFeign#924 Commas were used to identify iterable content, which conflicted when a comma delimited literal was provided during expansion. This change switches commas for semi-colons, which are considered reserved secondary delimiters in RFC 6750 and should not be used without being pct-encoded. Should be a safer choice.
47be0b9 to
3aa3350
Compare
velo
left a comment
There was a problem hiding this comment.
LGTM, just drop the un-used import
I need to preserve semicolon in the parameter value, is this possible with the SpringMvcContract ? With the current default implementation: filters=(order=ASC;attributeFilter=false;key=modified;start=2019/12/0612:04:00;) gets converted to: filters=(order=ASC&filters=attributeFilter=false&filters=key=modified&filters=start=2019%2F12%2F0603:32:00&filters=) |
|
Please see #1123 for a temporary workaround. |
Replaced comma with Constant Delimiter in Template Fixes #924 Commas were used to identify iterable content, which conflicted when a comma delimited literal was provided during expansion. This change switches commas for semi-colons, which are considered reserved secondary delimiters in RFC 6750 and should not be used without being pct-encoded. Should be a safer choice.
Replaced comma with Constant Delimiter in Template Fixes #924 Commas were used to identify iterable content, which conflicted when a comma delimited literal was provided during expansion. This change switches commas for semi-colons, which are considered reserved secondary delimiters in RFC 6750 and should not be used without being pct-encoded. Should be a safer choice.
Fixes #924
Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion. This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.
Should be a safer choice.