Skip to content

Replaced comma with Constant Delimiter in Template - #930

Merged
kdavisk6 merged 3 commits into
OpenFeign:masterfrom
kdavisk6:gh-924-collection-delimiters
Apr 8, 2019
Merged

kdavisk6 merged 3 commits into
OpenFeign:masterfrom
kdavisk6:gh-924-collection-delimiters

Conversation

@kdavisk6

Copy link
Copy Markdown
Member

Fixes #924

Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion. This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.

Should be a safer choice.

Fixes OpenFeign#924

Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion.  This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.

Should be a safer choice.
@kdavisk6
kdavisk6 force-pushed the gh-924-collection-delimiters branch from 47be0b9 to 3aa3350 Compare March 27, 2019 12:21
@kdavisk6
kdavisk6 requested a review from velo March 27, 2019 12:25
@kdavisk6 kdavisk6 added the bug Unexpected or incorrect behavior label Mar 27, 2019

@velo velo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just drop the un-used import

@velo velo added the ready to merge Will be merged if no other member ask for changes label Mar 28, 2019
@kdavisk6
kdavisk6 merged commit 7ba16df into OpenFeign:master Apr 8, 2019
@kdavisk6 kdavisk6 added this to the 10.2.1 milestone Apr 28, 2019
@kdavisk6
kdavisk6 deleted the gh-924-collection-delimiters branch May 9, 2019 13:51
@kdavisk6 kdavisk6 removed ready to merge Will be merged if no other member ask for changes labels May 11, 2019
@tpatrizio

tpatrizio commented Dec 6, 2019 •

Copy link
Copy Markdown

Fixes #924

Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion. This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.

Should be a safer choice.

I need to preserve semicolon in the parameter value, is this possible with the SpringMvcContract ?

With the current default implementation:

filters=(order=ASC;attributeFilter=false;key=modified;start=2019/12/0612:04:00;)

gets converted to:

filters=(order=ASC&filters=attributeFilter=false&filters=key=modified&filters=start=2019%2F12%2F0603:32:00&filters=)

@kdavisk6

kdavisk6 commented Dec 7, 2019

Copy link
Copy Markdown
Member Author

Please see #1123 for a temporary workaround.

velo pushed a commit that referenced this pull request Oct 7, 2024
Replaced comma with Constant Delimiter in Template

Fixes #924

Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion.  This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.

Should be a safer choice.
velo pushed a commit that referenced this pull request Oct 8, 2024
Replaced comma with Constant Delimiter in Template

Fixes #924

Commas were used to identify iterable content, which conflicted when
a comma delimited literal was provided during expansion.  This change
switches commas for semi-colons, which are considered reserved secondary
delimiters in RFC 6750 and should not be used without being pct-encoded.

Should be a safer choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query param with comma produce multiple query params

3 participants