When User and/or Password are too long, then the Authorization Header is broken#93
Conversation
|
feign-pull-requests #122 FAILURE |
|
you mind checking to see if this fixes it? If so, copy/paste is ok, as On Mon, Dec 2, 2013 at 4:03 PM, CloudBees pull request builder plugin <
|
|
@adriancole Yep, that worked |
|
great. make a copy and if you can get by with this being package private, On Mon, Dec 2, 2013 at 4:24 PM, Rodrigo Saito notifications@github.comwrote:
|
|
Updated PR |
|
nit sweep, then squash commits, please! Thanks for the help |
|
feign-pull-requests #123 SUCCESS |
|
feign-pull-requests #124 SUCCESS |
|
Updated @adriancole |
|
sorry @rodrigosaito I forgot to ask you to update CHANGES. Can you do that and resquash? |
|
Sure, version 7.0.0? or inside 6.0.0? On Mon, Dec 2, 2013 at 11:11 PM, Adrian Cole notifications@github.comwrote:
Rodrigo Saito |
|
feign-pull-requests #125 SUCCESS |
|
6.0.2 thx |
|
feign-pull-requests #126 SUCCESS |
… is broken because of sun Base64Encoder impl. Changed for another Base64 implementation
|
Done |
|
feign-pull-requests #127 SUCCESS |
When User and/or Password are too long, then the Authorization Header is broken
|
cherry-picked into 6.x |
|
@adriancole When are you planning to release 6.0.2? |
|
I don't have release karma. @allenxwang does :) |
When User and/or Password are too long, then the Authorization Header is broken
3 participants
I created the test that shows the problem.
This is probably caused by the sun Base64Encoder: sun.misc.BASE64Encoder
I cat provide a PR with the solution, but wasn't sure about the best approach. What do you think? Implement a new Base64Encoder class, add something like commons-codec to the project, replace the \n in the string generated by the Base64Encoder or there is any other implementation of Base64 already in the project?
Thouhgts?