Updated Query Expressions to support empty and undefined values#910
Merged
velo merged 1 commit intoMar 4, 2019
Merged
Conversation
Fixes OpenFeign#872 Previously, all unresolved query template expressions resolved to empty strings, which then indcate that the entire query parameter should be removed. This violates RFC 6570 in that only undefined values should be removed. This change updates Query Template to check the provided `variables` map for an entry expression. If no value is provided, the entry is explicitly marked `UNDEF` and removed. This brings us in line with the specification. The following is now how parameters are resolved: *Empty String* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); parameters.put("param", ""); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test?param= ``` *Missing* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test ``` *Undefined* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); parameters.put("param", null); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test ``` * Adding additional test case for explicit null parameter value * Additional Test case for the explict `null` case. Updates to the documentation.
kdavisk6
added
the
regression
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fixes #872 Previously, all unresolved query template expressions resolved to empty strings, which then indcate that the entire query parameter should be removed. This violates RFC 6570 in that only undefined values should be removed. This change updates Query Template to check the provided `variables` map for an entry expression. If no value is provided, the entry is explicitly marked `UNDEF` and removed. This brings us in line with the specification. The following is now how parameters are resolved: *Empty String* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); parameters.put("param", ""); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test?param= ``` *Missing* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test ``` *Undefined* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); parameters.put("param", null); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test ``` * Adding additional test case for explicit null parameter value * Additional Test case for the explict `null` case. Updates to the documentation.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fixes #872 Previously, all unresolved query template expressions resolved to empty strings, which then indcate that the entire query parameter should be removed. This violates RFC 6570 in that only undefined values should be removed. This change updates Query Template to check the provided `variables` map for an entry expression. If no value is provided, the entry is explicitly marked `UNDEF` and removed. This brings us in line with the specification. The following is now how parameters are resolved: *Empty String* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); parameters.put("param", ""); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test?param= ``` *Missing* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test ``` *Undefined* ```java public void test() { Map<String, Object> parameters = new LinkedHashMap<>(); parameters.put("param", null); this.demoClient.test(parameters); } ``` Result ``` http://localhost:8080/test ``` * Adding additional test case for explicit null parameter value * Additional Test case for the explict `null` case. Updates to the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #872
Previously, all unresolved query template expressions resolved
to empty strings, which then indcate that the entire query parameter
should be removed. This violates RFC 6570 in that only undefined
values should be removed. This change updates Query Template to
check the provided
variablesmap for an entry expression. Ifno value is provided, the entry is explicitly marked
UNDEFandremoved.
This brings us in line with the specification. The following is
now how parameters are resolved:
Empty String
Result
Missing
Result
Undefined
Result
Adding additional test case for explicit null parameter value
Additional Test case for the explict
nullcase. Updates to thedocumentation.