Skip to content

Allow 1xx status codes - #871

Merged
kdavisk6 merged 6 commits into
OpenFeign:masterfrom
maly7:support-1xx-status-codes
Feb 6, 2019
Merged

kdavisk6 merged 6 commits into
OpenFeign:masterfrom
maly7:support-1xx-status-codes

Conversation

@maly7

@maly7 maly7 commented Dec 31, 2018

Copy link
Copy Markdown
Contributor

Previously Response didn't allow status codes in the 1xx series, only 200 and beyond were allowed. This fixes that by allowing status codes in the range from 100 <= status < 600.

Fixes #836

@kdavisk6

Copy link
Copy Markdown
Member

Travis is unhappy due to formatting. Can you run Maven package locally? The build will fix any formatting for you. Once complete, please push a new commit.

@maly7

maly7 commented Dec 31, 2018

Copy link
Copy Markdown
Contributor Author

Sorry about that! It should hopefully be fixed now

@kdavisk6

kdavisk6 commented Jan 8, 2019

Copy link
Copy Markdown
Member

@maly7 our typical process is for one of the maintainers to review, and if approved, we give the others a few days to weigh in. After that, if there are no additional comments, we'll merge your PR. Thanks for your help!

@kdavisk6 kdavisk6 added bug Unexpected or incorrect behavior waiting for feedback Issues waiting for a response from either to the author or other maintainers labels Jan 8, 2019
Comment thread core/src/main/java/feign/Response.java Resolved
@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed waiting for feedback Issues waiting for a response from either to the author or other maintainers labels Feb 1, 2019
@kdavisk6

kdavisk6 commented Feb 1, 2019

Copy link
Copy Markdown
Member

@maly7

Thanks! Don't worry about the travis failures, there is an issue with the HTTP2 test case that is not related to your changes.

@kdavisk6
kdavisk6 merged commit e8366d0 into OpenFeign:master Feb 6, 2019
velo pushed a commit that referenced this pull request Oct 7, 2024
* add support for 1xx status codes in Response

* allow for any status code
velo pushed a commit that referenced this pull request Oct 8, 2024
* add support for 1xx status codes in Response

* allow for any status code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected or incorrect behavior ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IllegalStateException on 1xx response codes

3 participants