Skip to content

Fixes NPE when a Response does not provide headers - #855

Merged
velo merged 1 commit into
OpenFeign:masterfrom
kdavisk6:gh-853-npe-response-headers
Dec 11, 2018
Merged

velo merged 1 commit into
OpenFeign:masterfrom
kdavisk6:gh-853-npe-response-headers

Conversation

@kdavisk6

Copy link
Copy Markdown
Member

Fixes #853

There are some scenarios reported where a server does
not provide headers with the response. While this is
not typically expected, it's simple enough for Feign to
be resilient to it. This change checks the headers provided
in the builder and if none are provided, an empty map is
used in it's place.

Fixes OpenFeign#853

There are some scenarios reported where a server does
not provide headers with the response.  While this is
not typically expected, it's simple enough for Feign to
be resilient to it.  This change checks the headers provided
in the builder and if none are provided, an empty map is
used in it's place.
@velo
velo merged commit cf31cd1 into OpenFeign:master Dec 11, 2018
@kdavisk6
kdavisk6 deleted the gh-853-npe-response-headers branch February 6, 2019 19:36
velo pushed a commit that referenced this pull request Oct 7, 2024
Fixes #853

There are some scenarios reported where a server does
not provide headers with the response.  While this is
not typically expected, it's simple enough for Feign to
be resilient to it.  This change checks the headers provided
in the builder and if none are provided, an empty map is
used in it's place.
velo pushed a commit that referenced this pull request Oct 8, 2024
Fixes #853

There are some scenarios reported where a server does
not provide headers with the response.  While this is
not typically expected, it's simple enough for Feign to
be resilient to it.  This change checks the headers provided
in the builder and if none are provided, an empty map is
used in it's place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants