Skip to content

support PATCH with empty body paramter. - #824

Merged
velo merged 1 commit into
OpenFeign:masterfrom
alzipursky:empty-patch-requests
Oct 26, 2018
Merged

velo merged 1 commit into
OpenFeign:masterfrom
alzipursky:empty-patch-requests

Conversation

@alzipursky

Copy link
Copy Markdown
Contributor

Fixes #665

@alzipursky
alzipursky force-pushed the empty-patch-requests branch 2 times, most recently from ae03169 to 4f1547a Compare October 25, 2018 00:04
@alzipursky
alzipursky force-pushed the empty-patch-requests branch from 4f1547a to c422485 Compare October 25, 2018 00:14
@alzipursky alzipursky changed the title support PATCH with empth body paramter. support PATCH with empty body paramter. Oct 25, 2018

@velo velo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@velo velo added enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes labels Oct 26, 2018
@kdavisk6

Copy link
Copy Markdown
Member

The idea of a PATCH request without a body is still awkward to me. But, if folks want it, I'm cool with it.

@velo
velo merged commit b6d8bb1 into OpenFeign:master Oct 26, 2018
velo pushed a commit that referenced this pull request Oct 7, 2024
velo pushed a commit that referenced this pull request Oct 8, 2024
@matevskial

Copy link
Copy Markdown

@kdavisk6 Imagine Postman, for example, not allowing you to send a patch request without body because... it is awkward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PATCH does not allow a body that is null

4 participants