Skip to content

Stage feign 10 1 - #819

Merged
velo merged 4 commits into
OpenFeign:masterfrom
velo:stage-feign-10_1
Oct 27, 2018
Merged

velo merged 4 commits into
OpenFeign:masterfrom
velo:stage-feign-10_1

Conversation

@velo

@velo velo commented Oct 20, 2018

Copy link
Copy Markdown
Member

Found a few minor issues while testing staged feign build #818

@velo velo added bug Unexpected or incorrect behavior help wanted Issues we need help with tackling ready to merge Will be merged if no other member ask for changes labels Oct 20, 2018
@velo
velo force-pushed the stage-feign-10_1 branch 2 times, most recently from aafd23f to d3ecc43 Compare October 22, 2018 09:22
@velo
velo force-pushed the stage-feign-10_1 branch from d3ecc43 to 4b64fb7 Compare October 27, 2018 02:21
@velo
velo merged commit 8e84f5e into OpenFeign:master Oct 27, 2018
@velo
velo deleted the stage-feign-10_1 branch October 27, 2018 02:22
velo added a commit that referenced this pull request Oct 7, 2024
* NPE when resolving a template with binary body

* must cast to super class Buffer otherwise break when running with java 11

* Better error message for feign mock

* Recomend using Response.Builder on MockClient
velo added a commit that referenced this pull request Oct 8, 2024
* NPE when resolving a template with binary body

* must cast to super class Buffer otherwise break when running with java 11

* Better error message for feign mock

* Recomend using Response.Builder on MockClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected or incorrect behavior help wanted Issues we need help with tackling ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant