Repository navigation
Introduced java 11 module with http2 client - #806
Conversation
dcbdeb2 to
9c08600
Compare
| import feign.Request.Options; | ||
| import feign.Response; | ||
|
|
||
| public class JavaHttp2Client implements Client { |
There was a problem hiding this comment.
I don't think we need to have Java in the name. Can you rename it to Http2Client?
| matrix: | ||
| include: | ||
| - os: linux | ||
| jdk: oraclejdk8 |
There was a problem hiding this comment.
Should we also consider changing this to the openjdk?
| public void testPatch() throws Exception { | ||
| TestInterface api = newBuilder().target(TestInterface.class, "https://nghttp2.org/httpbin/"); | ||
| Assertions.assertThat(api.patch("")) | ||
| .contains("https://nghttp2.org/httpbin/patch"); |
There was a problem hiding this comment.
Won't this make a real call? Is there a way we can mock this out to prevent builds from failing due to network or host issues?
There was a problem hiding this comment.
I wanted to be sure it was hitting an http2 server....
No network in general means no build for maven =)
Do you know any http2 mocks?
| /** | ||
| * @see jdk.internal.net.http.common.Utils.DISALLOWED_HEADERS_SET | ||
| */ | ||
| private static final Set<String> DISALLOWED_HEADERS_SET; |
There was a problem hiding this comment.
Can you add another comment about why these headers are disallowed?
| @@ -0,0 +1,11 @@ | |||
| # feign-java1 | |||
kdavisk6
left a comment
There was a problem hiding this comment.
2 small documentation changes, then feel free to merge
|
|
||
| ```java | ||
| GitHub github = Feign.builder() | ||
| .client(new JavaHttp2Client()) |
There was a problem hiding this comment.
Now that we changed the name of the Client, we need to update this :)
* Introduced java 11 module with http2 client
* Introduced java 11 module with http2 client
I had an old project (https://github.com/velo/feign-java9) with new java http2 client...
Now that java 11 is out and client api is better defined... it would be a good time to include support onto feign