Skip to content

Simplify Decoder.Default by extending StringDecoder - #77

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
davidmc24:tweak-default-decoder
Sep 22, 2013
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
davidmc24:tweak-default-decoder

Conversation

@davidmc24

Copy link
Copy Markdown
Contributor

Previously, the default decoder had logic relating to responses that made it distinct from StringDecoder.
Now that that's handled elsewhere, the body of the decode methods had less meaningful differences.
I opted to maintain Decoder.Default for consistency with other default implementations. StringDecoder
is maintained as a separate class for backwards compatibility, and because it may be useful in the
future for clients to use a plain String decoder even if the default decoder starts having additional
capabilities.

Previously, the default decoder had logic relating to responses that made it distinct from StringDecoder.
Now that that's handled elsewhere, the body of the decode methods had less meaningful differences.
I opted to maintain Decoder.Default for consistency with other default implementations.  StringDecoder
is maintained as a separate class for backwards compatibility, and because it may be useful in the
future for clients to use a plain String decoder even if the default decoder starts having additional
capabilities.
@cloudbees-pull-request-builder

Copy link
Copy Markdown

feign-pull-requests #102 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Sep 22, 2013
Simplify Decoder.Default by extending StringDecoder
@codefromthecrypt
codefromthecrypt merged commit 2615cf2 into OpenFeign:master Sep 22, 2013
velo pushed a commit that referenced this pull request Oct 8, 2024
Simplify Decoder.Default by extending StringDecoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants