Repository navigation
Simplify Decoder.Default by extending StringDecoder - #77
Merged
codefromthecrypt merged 1 commit intoSep 22, 2013
Merged
Conversation
Previously, the default decoder had logic relating to responses that made it distinct from StringDecoder. Now that that's handled elsewhere, the body of the decode methods had less meaningful differences. I opted to maintain Decoder.Default for consistency with other default implementations. StringDecoder is maintained as a separate class for backwards compatibility, and because it may be useful in the future for clients to use a plain String decoder even if the default decoder starts having additional capabilities.
|
feign-pull-requests #102 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Sep 22, 2013
Simplify Decoder.Default by extending StringDecoder
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Simplify Decoder.Default by extending StringDecoder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the default decoder had logic relating to responses that made it distinct from StringDecoder.
Now that that's handled elsewhere, the body of the decode methods had less meaningful differences.
I opted to maintain Decoder.Default for consistency with other default implementations. StringDecoder
is maintained as a separate class for backwards compatibility, and because it may be useful in the
future for clients to use a plain String decoder even if the default decoder starts having additional
capabilities.