Repository navigation
Added testing only fixes Windows newlines. - #714
Merged
Merged
Conversation
Member
|
@karlnicholas does the build work fine on windows? Would you be interested on getting going for feign? |
Contributor
Author
|
@velo Hi, It does build and pass all tests on windows. Only issue would be the formatter plugin but that doesn't prevent building and unit testing. I forked and built feign because I was going to look into adding support for Spring Pageable for the spring-cloud-openfeign project (spring-cloud/spring-cloud-openfeign#26) and so want to look into that at this point. |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fixes to junit only tests for Windows platform newlines. Pretty much just put System.lineSeparator() everywhere except in jaxb where feign returns only UNIX specific newlines.