Skip to content

Added testing only fixes Windows newlines. - #714

Merged
velo merged 1 commit into
OpenFeign:masterfrom
karlnicholas:patch-windows-newlines
May 28, 2018
Merged

velo merged 1 commit into
OpenFeign:masterfrom
karlnicholas:patch-windows-newlines

Conversation

@karlnicholas

@karlnicholas karlnicholas commented May 26, 2018 •

Copy link
Copy Markdown
Contributor

Added fixes to junit only tests for Windows platform newlines. Pretty much just put System.lineSeparator() everywhere except in jaxb where feign returns only UNIX specific newlines.

@velo

velo commented May 28, 2018

Copy link
Copy Markdown
Member

@karlnicholas does the build work fine on windows?

Would you be interested on getting going for feign?
https://www.appveyor.com/

@velo
velo merged commit a25423c into OpenFeign:master May 28, 2018
@karlnicholas

karlnicholas commented May 28, 2018 •

Copy link
Copy Markdown
Contributor Author

@velo Hi, It does build and pass all tests on windows. Only issue would be the formatter plugin but that doesn't prevent building and unit testing. I forked and built feign because I was going to look into adding support for Spring Pageable for the spring-cloud-openfeign project (spring-cloud/spring-cloud-openfeign#26) and so want to look into that at this point.

@karlnicholas
karlnicholas deleted the patch-windows-newlines branch May 28, 2018 04:47
@kdavisk6 kdavisk6 added this to the 10.0 milestone Aug 10, 2018
velo pushed a commit that referenced this pull request Oct 7, 2024
velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants