Repository navigation
provide encoder/decoder in a module that addsTo = Feign.Defaults.class - #68
Conversation
|
@davidmc24 please take a look. I think this clears things up.. |
|
whoops junk in my commit PTAL |
|
feign-pull-requests #89 SUCCESS |
|
Code changes look good. Maybe add a entry to the changelog:
My first pass at the builder API had been using a form more similar to what Hystrix uses for Setter objects. Something like Feign.withTarget(Bank.class, "https://my.bank.com").andEncoder(encoder).build(). Since it's using the names of the fields as the setters, it makes sense to merge the builder and the module as you did. Thanks for the enhancement. |
|
thx for the changelog suggestion + the history on the builder design! fyi I'll be offline almost all today again and only other change pending from me is the SAX thing. |
provide encoder/decoder in a module that addsTo = Feign.Defaults.class
|
feign-pull-requests #90 SUCCESS |
provide encoder/decoder in a module that addsTo = Feign.Defaults.class
This clarifies that
Feign.Defaultscontains everything needed except anEncoderand aDecoder.In order to complete the graph, you'll want to
Feign.builder()and specify.decoder()andencoder()Feign.create(GitHub.class, "https://api.github.com", new GsonModule()).@Providesmethods for codec.