Skip to content

Sync release scripts with zipkin#647

Merged
velo merged 1 commit into
OpenFeign:masterfrom
velo:release
Mar 6, 2018
Merged

Sync release scripts with zipkin#647
velo merged 1 commit into
OpenFeign:masterfrom
velo:release

Conversation

@velo

@velo velo commented Mar 5, 2018

Copy link
Copy Markdown
Member

No description provided.

Comment thread RELEASE.md
$ BINTRAY_USER=adrianmole BINTRAY_KEY=ed6f20bde9123bbb2312b221 TRAVIS_PULL_REQUEST=false TRAVIS_TAG= TRAVIS_BRANCH=master travis/publish.sh
```

## First release of the year

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incidentally we don't use the license plugin at the moment here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check how hard would be to get it working

Comment thread travis/publish.sh Outdated
# - If a release commit fails to deploy for a transient reason, delete the broken version from bintray and click rebuild
elif is_travis_branch_master; then
./mvnw --batch-mode -s ./.settings.xml -Prelease -nsu -DskipTests deploy
./mvnw --batch-mode -s ./.settings.xml -Prelease -nsu -pl -:benchmarks -DskipTests deploy

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/benchmarks/benchmark/g though it isn't connected to the build anyway so not sure if presence of this will make the build fail or not..

Comment thread travis/publish.sh
fi

./mvnw install -nsu
# skip license on travis due to #1512

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until/unless we use the license plugin the license skip business is unrelated

@codefromthecrypt

Copy link
Copy Markdown

needs rebase likely due to headers update

@velo

velo commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

Done

@codefromthecrypt codefromthecrypt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when ready

@velo velo merged commit eb944cf into OpenFeign:master Mar 6, 2018
@velo velo deleted the release branch March 6, 2018 19:12
velo added a commit that referenced this pull request Oct 7, 2024
velo added a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants