Repository navigation
Fix ApacheHttpClient.getContentType() to use request charset as default - #566
Merged
Merged
Conversation
|
seems testable? maybe add a mockwebserver test so it doesn't break again? |
Contributor
Author
|
Added a test which fails on master and passes with this fix. |
|
nice job |
phymbert
pushed a commit
to phymbert/feign
that referenced
this pull request
Aug 22, 2017
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is to address an issue in
ApacheHttpClientwhere there is a charset specified inrequest.charset()but not in theContent-Typeheader.This causes a charset mismatch in the code below -
For example -
request.charset()=utf-8Content-Type=application/jsonThe
contentstring will be encoded inutf-8butStringEntitywill useISO-8859-1by default because there is no charset in the content type.This bug appears to have been introduced in 9.4.0 by pull request #453 .