fix gh-470, support the values of QueryMap starting with '{'#540
Merged
Conversation
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
very minor feedback. thanks for the help
| } | ||
|
|
||
| private static String urlEncode(Object arg) { | ||
| public static String urlEncode(Object arg) { |
| } | ||
|
|
||
| private static String urlDecode(String arg) { | ||
| public static String urlDecode(String arg) { |
There was a problem hiding this comment.
revert as this code isn't used in this PR
zhujf1989
pushed a commit
to zhujf1989/feign
that referenced
this pull request
Apr 25, 2017
zhujf1989
added a commit
to zhujf1989/feign
that referenced
this pull request
Apr 25, 2017
zhujf1989
added a commit
to zhujf1989/feign
that referenced
this pull request
May 3, 2017
…nClient。different from OpenFeign#540." This reverts commit 6ccea8a.
phymbert
pushed a commit
to phymbert/feign
that referenced
this pull request
Aug 22, 2017
phymbert
pushed a commit
to phymbert/feign
that referenced
this pull request
Aug 22, 2017
…OpenFeign#555) support the query values starting with {, when use RibbonClient。different from OpenFeign#540.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #470 (comment)