Repository navigation
default client: use custom HostnameVerifier if overridden - #54
Conversation
|
feign-pull-requests #65 SUCCESS |
|
+1 go ahead and put in a straight-forward test. I agree this needs to be here. |
|
Sure. I'll see what needs to be done to make this testable. |
|
Test added. |
|
feign-pull-requests #66 SUCCESS |
There was a problem hiding this comment.
while it is true that you guys own the copyright, our license header script will clobber this. As copyright statements in headers are really only advisory, do you mind changing this to Netflix? If it is important to track this specifically, you can add a NOTICE.txt and cite this file and Commerce Tech there.
There was a problem hiding this comment.
My understanding of the gradle license plugin is that the skipExistingHeaders configuration setting (as this project has set in /gradle/license.gradle) is intended to allow files that already have headers to not be clobbered. Regardless, I'm fine with changing it if desired.
There was a problem hiding this comment.
personally I don't care :) just would prefer to code vs ask about license header exception
There was a problem hiding this comment.
Fine by me. I'll make the change and squash.
|
one license header nit, then if you don't mind squashing the commits. good job. |
Sometimes, it's useful to override the hostname verifier for SSL connections. One example, would be when you're developing against a test server managed by another company that's using a self-signed certificate with a mis-matched hostname. This patch enables that usage by overriding the default HostnameVerifier in a Dagger module. Adding test coverage required switching the TrustingSSLSocketFactory from using an anonymous cipher suite to one that authenticates. A test keystore is used for this purpose. It contains two self-signed certificates, one each with alias (and CN) "localhost" and "bad.example.com". The TrustingSSLSocketFactory is no longer a singleton; it now optionally takes a key alias as an argument.
|
License changed to use netflix standard, NOTICE file added, all commits squashed. |
|
feign-pull-requests #67 SUCCESS |
default client: use custom HostnameVerifier if overridden
|
cherry-picked into 4.x note I forgot to ask you to put in a blurb in CHANGES.md. Can you piggyback that onto your next PR? thanks! |
|
Sure thing. Based on your cherry picking into the 4.x branch, is 4.4 likely the next release? Is master the preferred branch for pull requests? |
|
Master is still best until we refactor on the "simplify" issue On Wednesday, August 28, 2013, David M. Carr wrote:
|
Add OpenFeign 10 support and update test accordingly
default client: use custom HostnameVerifier if overridden
Sometimes, it's useful to override the hostname verifier for SSL connections... for example, when you're developing against a test server managed by another company that's using a self-signed certificate with a mis-matched hostname. This patch enables that usage by overriding the default HostnameVerifier in a Dagger module.
I haven't included any tests in the initial submission. In order to test this behavior, we'd need to perform actual certificate negotiation, which TrustingSSLSocketFactory currently avoids. If test coverage for this is desired, I'm willing to contribute it, but didn't want to spend the time on it unless the enhancements to TrustingSSLSocketFactory were desired.