Repository navigation
Fix readme method name to produce client based in Target<T> - #502
Merged
codefromthecrypt merged 2 commits intoDec 5, 2016
Merged
Conversation
Contributor
|
Why? That's a major rename that I'm not keen on doing |
|
this is actually a doc bug. it is subtle because few use the newInstance method. Maybe it would be better to switch the reference to builder (as opposed to .build(); then .newInstance) https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/Feign.java#L92 |
Contributor
Author
|
@spencergibb I've modified that because As @adriancole suggested I just the doc to |
|
thanks @MarcelDiass! |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Fix method name to produce client based in Target<T> * Move from build().newInstance to .target()
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Fix method name to produce client based in Target<T> * Move from build().newInstance to .target()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix readme method name to produce client based in Target
From
To