Skip to content

Make Util.decodeOrDefault(...) public. - #493

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
rfalke:make-decodeOrDefault-public
Nov 14, 2016
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
rfalke:make-decodeOrDefault-public

Conversation

@rfalke

@rfalke rfalke commented Nov 10, 2016

Copy link
Copy Markdown
Contributor

The method is used for Loggers which may not live in the feign package.

The method is used for Loggers which may not live in the feign package.
@codefromthecrypt

Copy link
Copy Markdown

I don't really like feign's Util being used by other code because we can't change it whenever we like when that's the case. Ex we don't want to be guava. On the other hand, I've noticed we haven't ever marked this as internal, so in a way we are messy anyway. Moreover, this is the only non-public method, it seems. So, I guess it is ok.

@codefromthecrypt
codefromthecrypt merged commit 4eff532 into OpenFeign:master Nov 14, 2016
velo pushed a commit that referenced this pull request Oct 7, 2024
The method is used for Loggers which may not live in the feign package.
velo pushed a commit that referenced this pull request Oct 8, 2024
The method is used for Loggers which may not live in the feign package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants