Skip to content

Allow ErrorDecoder.decode(...) to return null. - #488

Closed
rfalke wants to merge 2 commits into
OpenFeign:masterfrom
rfalke:allow-null-returns
Closed

rfalke wants to merge 2 commits into
OpenFeign:masterfrom
rfalke:allow-null-returns

Conversation

@rfalke

@rfalke rfalke commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

Null signals that no exception should be thrown. This allows to
react to non-200 statuses not only with an exception but also
to return such statuses encoded somehow in the return object.

Null signals that no exception should be thrown. This allows to
react to non-200 statuses not only with an exception but also
to return such statuses encoded somehow in the return object.
@codefromthecrypt

Copy link
Copy Markdown

generally, I don't like this signal as it can lead to NPE or other cases where exception handling no longer applies. I'd like a few others to say they like it before merging

@codefromthecrypt

Copy link
Copy Markdown

didn't get any support in several months. closing until interest resumes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants