Skip to content

Also wrap the exception of Decoder.decode() in case of a 404. - #487

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
rfalke:uniform-decoding-exception-handling
Nov 8, 2016
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
rfalke:uniform-decoding-exception-handling

Conversation

@rfalke

@rfalke rfalke commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

No description provided.

}

@Test
public void decoderCanThrowUnwrappedExceptionInDecode404Mode() throws Exception {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is making the behavior the opposite of the test case. I'm ok with merging this, but if it gets kick-back we'd revert in a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants