Add Builder class to JAXBDecoder for disabling namespace-awareness.#471
Merged
Conversation
spencergibb
suggested changes
Oct 5, 2016
spencergibb
left a comment
spencergibb
left a comment
Contributor
There was a problem hiding this comment.
How about a little documentation in the jaxb readme?
| } | ||
|
|
||
| private JAXBDecoder(Builder builder) { | ||
| if (builder.jaxbContextFactory == null) { |
Contributor
There was a problem hiding this comment.
Seems like this could go in build().
Contributor
Author
|
Would you prefer this rebased & squashed? |
Contributor
|
yes please |
Contributor
Author
|
@spencergibb squashed :) |
spencergibb
suggested changes
Oct 5, 2016
spencergibb
left a comment
spencergibb
left a comment
Contributor
There was a problem hiding this comment.
Trying to do my best @adriancole impression :-) I forgot to have you update https://github.com/OpenFeign/feign/blob/master/CHANGELOG.md under 9.4, sorry.
|
Hehe so far so good :)
|
Contributor
Author
|
No problem 😄 Added (most of) the commit message to the changelog |
spencergibb
suggested changes
Oct 6, 2016
| @@ -1,3 +1,7 @@ | |||
| ### Version 9.4 | |||
| * Adds Builder class to JAXBDecoder for disabling namespace-awareness. | |||
| * Makes the SAX parser namespace aware by default (as it was prior to #415) | |||
| @@ -1,3 +1,7 @@ | |||
| ### Version 9.4 | |||
| * Adds Builder class to JAXBDecoder for disabling namespace-awareness. | |||
Contributor
There was a problem hiding this comment.
add '(defaults to true)'.
Contributor
Author
|
@spencergibb I don't think you get notified when I push new changes so just FYI I made the requested changes |
Contributor
|
It does, I was on leave. |
spencergibb
approved these changes
Oct 11, 2016
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the SAX parser namespace aware by default (as it was previously for JAXB).
Fixes #456