Skip to content

Make logRetry() and logIOException() protected#469

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
rfalke:make-protected
Sep 29, 2016
Merged

Make logRetry() and logIOException() protected#469
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
rfalke:make-protected

Conversation

@rfalke

@rfalke rfalke commented Sep 27, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rfalke

rfalke commented Sep 27, 2016

Copy link
Copy Markdown
Contributor Author

Fix for #468

@rfalke rfalke changed the title Make logRetry() and logIOException() protected (#468) Make logRetry() and logIOException() protected Sep 27, 2016
@codefromthecrypt

Copy link
Copy Markdown

I see your point. we usually don't open things until they are asked for, and in this case I don't see any harm doing so.

@codefromthecrypt codefromthecrypt merged commit 0e4a1c8 into OpenFeign:master Sep 29, 2016
@EXPEkmajewski

Copy link
Copy Markdown

I am also interested in consuming this fix. Any idea when it will be released? Thanks.

@rfalke

rfalke commented Nov 8, 2016

Copy link
Copy Markdown
Contributor Author

Well it is not in 9.3.1. No idea when the next version will be created.
@adriancole ?

@codefromthecrypt

Copy link
Copy Markdown

9.4 on the way now! thanks for the nag

On Tue, Nov 8, 2016 at 9:17 PM, rfalke notifications@github.com wrote:

Well it is not in 9.3.1. No idea when the next version will be created.
@adriancole https://github.com/adriancole ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#469 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD61yuwaJTDq33WSwtVHCSW4hK8L6RPks5q8HZxgaJpZM4KH6yt
.

velo pushed a commit that referenced this pull request Oct 7, 2024
velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants