Make Hystrix Command keys more unique #444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param method The fallback method. | ||
| * @return A unique key to be used to cache the Hystrix command. | ||
| */ | ||
| protected String generateCommandKey(Method method) { |
Contributor
There was a problem hiding this comment.
type is final so no need to talk about the difference between default impl and the actual impl (nor make it protected). nit.. uhh.. I think you forgot to call this method :)
ps LOVE the first two sentences of the docs.. the rest aren't needed as this will only be viewed by authors.
Author
There was a problem hiding this comment.
ha! and I also forgot to add feign# to the beginning of it.
Contributor
|
closed via #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses fallback method signature as the Hystrix command key. Fixes #434.