Skip to content

Adds support for encoded query parameters in @QueryMap - #408

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
koiuo:querymap_encoded
Jul 9, 2016
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
koiuo:querymap_encoded

Conversation

@koiuo

@koiuo koiuo commented Jun 23, 2016 •

Copy link
Copy Markdown
Contributor

Added support for encoded query parameters in QueryMap.

@koiuo
koiuo force-pushed the querymap_encoded branch 2 times, most recently from 1e35b23 to c12e203 Compare July 9, 2016 06:00
@koiuo koiuo changed the title [WIP] Encoded property for @QueryMap and its handling in Default contract Encoded property for @QueryMap and its handling in Default contract Jul 9, 2016
@koiuo

koiuo commented Jul 9, 2016

Copy link
Copy Markdown
Contributor Author

Updated as discussed on netflix/feign channel: we do not cover edge cases that are very unlikely in real-world applications.

@koiuo
koiuo force-pushed the querymap_encoded branch from c12e203 to 48f792b Compare July 9, 2016 06:09
@codefromthecrypt

Copy link
Copy Markdown

looks good. update CHANGES and cleanup the PR description, if you don't mind (notably showing what you do now)

@koiuo koiuo changed the title Encoded property for @QueryMap and its handling in Default contract encoded property for @QueryMap and its handling in Default contract Jul 9, 2016
@koiuo koiuo changed the title encoded property for @QueryMap and its handling in Default contract @QueryMap.encoded() and its handling in Default contract Jul 9, 2016
@koiuo
koiuo force-pushed the querymap_encoded branch from 48f792b to 15b2890 Compare July 9, 2016 06:41
@koiuo koiuo changed the title @QueryMap.encoded() and its handling in Default contract Adds support for encoded query parameters in @QueryMap Jul 9, 2016
* Add `@QueryMap.encoded()` property
* Implemnt `@QueryMap.encoded()` handling in Default contract
* Add overloaded `query` methods to `RequestTemplate` to set encoded
query parameters
@koiuo
koiuo force-pushed the querymap_encoded branch from 15b2890 to 87bfccd Compare July 9, 2016 06:47
@koiuo

koiuo commented Jul 9, 2016

Copy link
Copy Markdown
Contributor Author

Sorry for numerous edits and amendments, got a little confused. I believe I'm done now.

@codefromthecrypt
codefromthecrypt merged commit 968f35f into OpenFeign:master Jul 9, 2016
@codefromthecrypt

Copy link
Copy Markdown

Good work @edio

codefromthecrypt pushed a commit that referenced this pull request Jul 14, 2016
Adds support for encoded query parameters in `@QueryMap` via `@QueryMap(encoded = true)`
velo pushed a commit that referenced this pull request Oct 7, 2024
Adds support for encoded query parameters in `@QueryMap` via `@QueryMap(encoded = true)`
velo pushed a commit that referenced this pull request Oct 8, 2024
Adds support for encoded query parameters in `@QueryMap` via `@QueryMap(encoded = true)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants