to facilitate higher reuse, remove guava and jax-rs deps#4
Merged
codefromthecrypt merged 2 commits intomasterfrom Jul 1, 2013
Merged
to facilitate higher reuse, remove guava and jax-rs deps#4codefromthecrypt merged 2 commits intomasterfrom
codefromthecrypt merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
well the intent is no deps except dagger api, which is only 5 classes. |
Contributor
Author
|
updated to bump jax-rs to an optional extension; revised desc |
|
feign-pull-requests #15 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jul 1, 2013
to facilitate higher reuse, remove guava and jax-rs deps
|
+1 |
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
to facilitate higher reuse, remove guava and jax-rs deps
velo
pushed a commit
to hosuaby/feign
that referenced
this pull request
Nov 4, 2024
Rebased and updated: OSCR-849 Enabling the option to use HTTPS/2 for REST calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussions, it seems guava is not a good candidate as a dependency for highly reusable software. While switching off guava adds ~200 lines of code, it removes risk of version conflicts systemic to the guava ecosystem. Eventhough JAX-RS is a relatively stable dep, there's a new version 2.0 which implies another possible version clash.
This change introduces new
@RequestLineand@Headersannotations and moves jax-rs support to an optional module.ex.
cc @allenxwang @benjchristensen