Skip synthetic/bridge methods in BaseContract parsing - #3516
Closed
AzazelSensei wants to merge 1 commit into
Closed
Conversation
Covariant overrides generate unannotated bridge methods that BaseContract previously tried to parse, failing inheritance tests such as overrideParameterizedApiSupported. Fixes OpenFeign#2752
AzazelSensei
marked this pull request as ready for review
August 12, 2026 08:38
Author
|
Superseded by #3517. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract.BaseContract.parseAndValidateMetadatawalksClass.getMethods()but did not skip compiler-generated methods. Covariant overrides produce synthetic bridge methods without HTTP annotations, which then fail withMethod … not annotated with HTTP method type.This skips
isSynthetic()/isBridge()methods in that loop so inheritance cases likeoverrideParameterizedApiSupportedandmultipleInheritanceDoneCorrectly2parse cleanly.Related
Fixes the remaining
DefaultContractInheritanceTestfailures from #2752 (JUL/MultipleLoggerTestside is handled separately).Test plan
mvn test -pl core -Dtest=DefaultContractInheritanceTest(9 tests, 0 failures)