Skip to content

Apache HTTP client hates to have the Content-Length set - #324

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
dsyer:fix/httpclient
Feb 3, 2016
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
dsyer:fix/httpclient

Conversation

@dsyer

@dsyer dsyer commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

It always sets the header itself and if we set it as well it barfs
so it is better just to avoid setting it at all.

It always sets the header itself and if we set it as well it barfs
so it is better just to avoid setting it at all.
@dsyer

dsyer commented Feb 3, 2016

Copy link
Copy Markdown
Contributor Author

Example:

Caused by: org.apache.http.ProtocolException: Content-Length header already present
    at org.apache.http.protocol.RequestContent.process(RequestContent.java:96)
    at org.apache.http.protocol.ImmutableHttpProcessor.process(ImmutableHttpProcessor.java:132)
    at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:182)
    at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
    at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
    at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
    ... 118 more

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #206 SUCCESS
This pull request looks good

dsyer pushed a commit to spring-cloud/spring-cloud-netflix that referenced this pull request Feb 3, 2016
Also does not rename another one because it fails (see gh-804). The
bug can be fixed in feign (OpenFeign/feign#324),
and if that gets merged and released we can revert some of the recent
changes to the apache load balancer here.
codefromthecrypt pushed a commit that referenced this pull request Feb 3, 2016
Apache HTTP client hates to have the Content-Length set
@codefromthecrypt
codefromthecrypt merged commit 7464d5e into OpenFeign:master Feb 3, 2016
@codefromthecrypt

Copy link
Copy Markdown

thx! lemme know how urgent this is to release

@dsyer

dsyer commented Feb 3, 2016

Copy link
Copy Markdown
Contributor Author

Would be good to have it this week for Spring Cloud Netflix milestone. But if not we always have the other clients.

@codefromthecrypt codefromthecrypt added this to the 8.14.3 milestone Feb 3, 2016
velo pushed a commit that referenced this pull request Oct 8, 2024
Apache HTTP client hates to have the Content-Length set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants