Skip to content

support PUT with empty body parameter#322

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
pnepywoda:empty-body
Jan 26, 2016
Merged

support PUT with empty body parameter#322
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
pnepywoda:empty-body

Conversation

@pnepywoda

Copy link
Copy Markdown

follow-up commit to #271

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #201 SUCCESS
This pull request looks good

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.14 has left the building! 8.15 :)

@codefromthecrypt

Copy link
Copy Markdown

PUT with no content is semantically weird, but yeah understood.

LGTM after filing into 8.15 in the changelog

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #202 SUCCESS
This pull request looks good

@codefromthecrypt

Copy link
Copy Markdown

@pnepywoda mind squashing into one commit? easier for me to click merge vs cherry-pick and squash on my end

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #203 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Jan 26, 2016
support PUT with empty body parameter
@codefromthecrypt codefromthecrypt merged commit 5281e62 into OpenFeign:master Jan 26, 2016
@codefromthecrypt

Copy link
Copy Markdown

thx! let me know if a release is urgent

@pnepywoda

Copy link
Copy Markdown
Author

We are waiting on this to get released...if it could happen this week it
would be great!

On Tue, Jan 26, 2016 at 2:15 AM, Adrian Cole notifications@github.com
wrote:

thx! let me know if a release is urgent


Reply to this email directly or view it on GitHub
#322 (comment).

@pnepywoda pnepywoda deleted the empty-body branch January 26, 2016 10:52
@pnepywoda

Copy link
Copy Markdown
Author

@adriancole actually it's become urgent on our end. Any possibility of release soon?

@codefromthecrypt

codefromthecrypt commented Jan 27, 2016 via email

Copy link
Copy Markdown

@spencergibb

Copy link
Copy Markdown
Contributor

I'd be happy to be the backup, though I haven't returned from surgery leave yet.

@codefromthecrypt

codefromthecrypt commented Jan 27, 2016 via email

Copy link
Copy Markdown

@codefromthecrypt

codefromthecrypt commented Jan 27, 2016 via email

Copy link
Copy Markdown

velo pushed a commit that referenced this pull request Oct 8, 2024
support PUT with empty body parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants