Repository navigation
Provides a nicer error when a user omits the http method - #311
Merged
Merged
Conversation
Before this change, if someone accidentally left out the HTTP method in a `@RequestLine` annotation, they'd get an undecipherable error like: "Body parameters cannot be used with form parameters." from Contract.java. This makes the omission easier to find by changing the message to: "RequestLine annotation didn't start with an HTTP verb..." Fixes #310
|
NetflixOSS » feign » feign-pull-requests #199 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jan 10, 2016
Provides a nicer error when a user omits the http method
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Provides a nicer error when a user omits the http method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, if someone accidentally left out the HTTP method in
a
@RequestLineannotation, they'd get an undecipherable error like:"Body parameters cannot be used with form parameters." from Contract.java.
This makes the omission easier to find by changing the message to:
"RequestLine annotation didn't start with an HTTP verb..."
Fixes #310