Skip to content

Provides a nicer error when a user omits the http method - #311

Merged
codefromthecrypt merged 1 commit into
masterfrom
nicer-error
Jan 10, 2016
Merged

codefromthecrypt merged 1 commit into
masterfrom
nicer-error

Conversation

@codefromthecrypt

Copy link
Copy Markdown

Before this change, if someone accidentally left out the HTTP method in
a @RequestLine annotation, they'd get an undecipherable error like:

"Body parameters cannot be used with form parameters." from Contract.java.

This makes the omission easier to find by changing the message to:

"RequestLine annotation didn't start with an HTTP verb..."

Fixes #310

Before this change, if someone accidentally left out the HTTP method in
a `@RequestLine` annotation, they'd get an undecipherable error like:

"Body parameters cannot be used with form parameters." from Contract.java.

This makes the omission easier to find by changing the message to:

"RequestLine annotation didn't start with an HTTP verb..."

Fixes #310
@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #199 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Jan 10, 2016
Provides a nicer error when a user omits the http method
@codefromthecrypt
codefromthecrypt merged commit 9c07cb0 into master Jan 10, 2016
@codefromthecrypt
codefromthecrypt deleted the nicer-error branch January 10, 2016 08:52
velo pushed a commit that referenced this pull request Oct 8, 2024
Provides a nicer error when a user omits the http method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants