Repository navigation
Allow responses to be streamed. - #302
Conversation
|
NetflixOSS » feign » feign-pull-requests #181 SUCCESS |
f435afb to
b61285e
Compare
|
NetflixOSS » feign » feign-pull-requests #182 SUCCESS |
There was a problem hiding this comment.
I think we should forbid this being -1, as it is redundant with the semantics of null. ex. enforce in InputStreamBody ctor as -1 should be a bug. Have you ever seen this assigned to -1 in feign?
There was a problem hiding this comment.
Good call, I have not seen a negative value there.
I also think that checking isRepeatable() is wrong in the above condition, it may have to get resolved before being closed. I'll remove that part of the conditional.
|
looking good. let me know when you are ready for realz |
b61285e to
2b038c2
Compare
|
NetflixOSS » feign » feign-pull-requests #183 SUCCESS |
Never expands >8kb responses into memory
2b038c2 to
ef01751
Compare
|
Cleaned up the tests, I think we're good to go :-) |
|
NetflixOSS » feign » feign-pull-requests #184 SUCCESS |
|
oops one last thing add a note in the CHANGELOG for 8.13
Thanks tons for making a compatible way to address this feature!
|
|
nm I'll work this out on the way in |
Allow responses to be streamed.
|
Sorry about that, fell asleep. Thanks for reviewing/merging so quickly! |
|
sorry this never made it out. I've now released it in 8.16.2 |
Never expands >8kb responses into memory
It seems less dangerous to avoid closing Response objects than to explode large responses in memory