Skip to content

Allow responses to be streamed. - #302

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
carterkozak:ckozak/stream_response
Dec 15, 2015
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
carterkozak:ckozak/stream_response

Conversation

@carterkozak

Copy link
Copy Markdown

Never expands >8kb responses into memory

It seems less dangerous to avoid closing Response objects than to explode large responses in memory

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #181 SUCCESS
This pull request looks good

@carterkozak
carterkozak force-pushed the ckozak/stream_response branch from f435afb to b61285e Compare December 15, 2015 03:14
@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #182 SUCCESS
This pull request looks good

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should forbid this being -1, as it is redundant with the semantics of null. ex. enforce in InputStreamBody ctor as -1 should be a bug. Have you ever seen this assigned to -1 in feign?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I have not seen a negative value there.
I also think that checking isRepeatable() is wrong in the above condition, it may have to get resolved before being closed. I'll remove that part of the conditional.

@codefromthecrypt

Copy link
Copy Markdown

looking good. let me know when you are ready for realz

@carterkozak
carterkozak force-pushed the ckozak/stream_response branch from b61285e to 2b038c2 Compare December 15, 2015 05:08
@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #183 SUCCESS
This pull request looks good

Never expands >8kb responses into memory
@carterkozak
carterkozak force-pushed the ckozak/stream_response branch from 2b038c2 to ef01751 Compare December 15, 2015 05:14
@carterkozak

Copy link
Copy Markdown
Author

Cleaned up the tests, I think we're good to go :-)
Thanks!

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #184 SUCCESS
This pull request looks good

@codefromthecrypt

codefromthecrypt commented Dec 15, 2015 via email

Copy link
Copy Markdown

@codefromthecrypt

Copy link
Copy Markdown

nm I'll work this out on the way in

codefromthecrypt pushed a commit that referenced this pull request Dec 15, 2015
@codefromthecrypt
codefromthecrypt merged commit 10ee72c into OpenFeign:master Dec 15, 2015
@carterkozak

Copy link
Copy Markdown
Author

Sorry about that, fell asleep. Thanks for reviewing/merging so quickly!
Any idea when to expect 8.13 to be published to maven?

@codefromthecrypt codefromthecrypt added this to the 8.16.2 milestone Apr 23, 2016
@codefromthecrypt

Copy link
Copy Markdown

sorry this never made it out. I've now released it in 8.16.2

velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants