Skip to content

Conversation

@DRoppelt
Copy link
Contributor

fixes GHSA-vv7r-c36w-3prj

It does not seem like form-spring would be affected, but this would fix any of the dumb auditing tools that only look for the presence of libs

@DRoppelt DRoppelt changed the title bump commons-fileupload to fix CVE-2025-48976 bump commons-fileupload to fix CVE-2025-48976 (form-spring) Jul 18, 2025
@DRoppelt
Copy link
Contributor Author

duplicate of #2940

@DRoppelt
Copy link
Contributor Author

DRoppelt commented Aug 13, 2025

feign-vertx appears to be crunchy, https://app.circleci.com/pipelines/github/OpenFeign/feign/3980/workflows/39943145-aa46-4d8d-ab39-e95da93e0181/jobs/9602 failed where https://app.circleci.com/pipelines/github/OpenFeign/feign/3981/workflows/d64c1fae-3704-4898-9abe-4f05b44c6f2d/jobs/9604 was a re-run done via a squash of two commits

[feign-vertx] [ERROR] Errors: 
[feign-vertx] [ERROR]   TimeoutHandlingTest.whenTimeoutIsNotReached(VertxTestContext) » NoStackTraceTimeout The timeout period of 1000ms has been exceeded while executing GET /icecream/flavors for server localhost:43411
[feign-vertx] [INFO] 
[feign-vertx] [ERROR] Tests run: 25, Failures: 0, Errors: 1, Skipped: 2
[feign-vertx] [INFO] 

Also, bump from commons-fileupload 1.5 to 1.6.0 caused moditect to fail, other modules ignore it too, doing it here as well
the skip property ignores this error
[ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.3.0.Final:add-module-info (add-module-infos) on project feign-form-spring: Execution add-module-infos of goal org.moditect:moditect-maven-plugin:1.3.0.Final:add-module-info failed: Module portlet.api not found, required by org.apache.commons.fileupload

I tried to configure/tweak moditect-maven-plugin, but found what the plugin does or what kind of config is required confusing and gave up. It sounds like a "form-spring requires portlet.api, because of commons-fileupload" (duh), the plugin docs were not straight forward to declare that module-requirement

bump from commons-fileupload 1.5 to 1.6.0 caused moditect to fail, other modules ignore it too, doing it here as well
ignores:
 [ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.3.0.Final:add-module-info (add-module-infos) on project feign-form-spring: Execution add-module-infos of goal org.moditect:moditect-maven-plugin:1.3.0.Final:add-module-info failed: Module portlet.api not found, required by org.apache.commons.fileupload

<properties>
<main.java.version>17</main.java.version>
<moditect.skip>true</moditect.skip>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so tempted to remove moditect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants