Skip to content

Skips error handling when return type is Response - #269

Merged
codefromthecrypt merged 1 commit into
masterfrom
dont-handle-response
Sep 9, 2015
Merged

codefromthecrypt merged 1 commit into
masterfrom
dont-handle-response

Conversation

@codefromthecrypt

Copy link
Copy Markdown

In unsuccessful scenarios, such as redirects, error handling converts a
Response into an exception. When a user defines a return type as
Response, we can assume they will want access to things like headers
even in an error scenario.

See #249

In unsuccessful scenarios, such as redirects, error handling converts a
`Response` into an exception. When a user defines a return type as
`Response`, we can assume they will want access to things like headers
even in an error scenario.

See #249
@codefromthecrypt

Copy link
Copy Markdown
Author

@sbuettner PTAL!

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #145 SUCCESS
This pull request looks good

@sbuettner

Copy link
Copy Markdown

Looks good! 👍

codefromthecrypt pushed a commit that referenced this pull request Sep 9, 2015
Skips error handling when return type is Response
@codefromthecrypt
codefromthecrypt merged commit 129f9a4 into master Sep 9, 2015
@codefromthecrypt
codefromthecrypt deleted the dont-handle-response branch September 9, 2015 12:41
@codefromthecrypt codefromthecrypt added this to the 8.9.0 milestone Sep 9, 2015
@codefromthecrypt

Copy link
Copy Markdown
Author

@sbuettner 8.9.0 includes this.. lemme know if you are able to get things done now

@sbuettner

Copy link
Copy Markdown

Is it published?

@codefromthecrypt

codefromthecrypt commented Sep 9, 2015 via email

Copy link
Copy Markdown
Author

@sbuettner

Copy link
Copy Markdown

Works! Thank you for your time. 😄

velo pushed a commit that referenced this pull request Oct 8, 2024
Skips error handling when return type is Response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants