Repository navigation
Skips error handling when return type is Response - #269
Merged
Merged
Conversation
In unsuccessful scenarios, such as redirects, error handling converts a `Response` into an exception. When a user defines a return type as `Response`, we can assume they will want access to things like headers even in an error scenario. See #249
Author
|
@sbuettner PTAL! |
|
NetflixOSS » feign » feign-pull-requests #145 SUCCESS |
|
Looks good! 👍 |
codefromthecrypt
pushed a commit
that referenced
this pull request
Sep 9, 2015
Skips error handling when return type is Response
Author
|
@sbuettner 8.9.0 includes this.. lemme know if you are able to get things done now |
|
Is it published? |
Author
|
yep. just maven's search cache doesn't see it, yet
https://repo1.maven.org/maven2/com/netflix/feign/feign-core/8.9.0/
|
|
Works! Thank you for your time. 😄 |
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Skips error handling when return type is Response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In unsuccessful scenarios, such as redirects, error handling converts a
Responseinto an exception. When a user defines a return type asResponse, we can assume they will want access to things like headerseven in an error scenario.
See #249