Skip to content

264 body decoding - #268

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
ddteeter:264-body-decoding
Sep 9, 2015
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
ddteeter:264-body-decoding

Conversation

@ddteeter

@ddteeter ddteeter commented Sep 8, 2015

Copy link
Copy Markdown

Fixes #264

Switches body parameter substitution to use encoded parameters. Resolves issue where some characters (+ %..) would end up double decoded if existing in parameters.

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #144 SUCCESS
This pull request looks good

@codefromthecrypt

Copy link
Copy Markdown

denominator tests pass.. so I think we're good. nice fix!

mind squashing these into a single commit with message

Switches body parameter substitution to use encoded parameters

Resolves issue where some characters (+ %..) would end up double decoded if existing in parameters.

Fixes #264

Resolves issue where some characters (+ %..) would end up double decoded if existing in parameters.

Fixes OpenFeign#264
@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #146 SUCCESS
This pull request looks good

@codefromthecrypt

Copy link
Copy Markdown

gracias!

codefromthecrypt pushed a commit that referenced this pull request Sep 9, 2015
@codefromthecrypt
codefromthecrypt merged commit 69a8779 into OpenFeign:master Sep 9, 2015
@codefromthecrypt codefromthecrypt added this to the 8.9.0 milestone Sep 9, 2015
@codefromthecrypt

Copy link
Copy Markdown

out in the wild, in v8.9.0

@codefromthecrypt

Copy link
Copy Markdown

thanks for the help with this!

velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants