Fixed extracting charset from response.#2545
Merged
Merged
Conversation
Member
|
Please correct the build by running |
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes OpenFeign#2540
Contributor
Author
|
I ran install with toolchain skipped. License header was changed. I also added parametrized test to FeignExceptionTest to cover different cases. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Some suggestions could not be made:
- annotation-error-decoder/pom.xml
- lines 32-31
- apt-test-generator/pom.xml
- lines 33-32
- lines 62-61
- benchmark/pom.xml
- lines 31-30
- core/pom.xml
- lines 32-31
- dropwizard-metrics4/pom.xml
- lines 30-29
- dropwizard-metrics5/pom.xml
- lines 30-29
- example-github-with-coroutine/pom.xml
- lines 32-31
- example-github/pom.xml
- lines 32-31
- example-wikipedia-with-springboot/pom.xml
- lines 33-32
- example-wikipedia/pom.xml
- lines 33-32
- fastjson2/pom.xml
- lines 32-31
- googlehttpclient/pom.xml
- lines 32-31
- gson/pom.xml
- lines 32-31
- hc5/pom.xml
- lines 32-31
- httpclient/pom.xml
- lines 32-31
- hystrix/pom.xml
- lines 32-31
- jackson-jaxb/pom.xml
- lines 32-31
- lines 82-83
- jackson-jr/pom.xml
- lines 32-31
- jackson/pom.xml
- lines 32-31
- jakarta/pom.xml
- lines 33-32
- java11/pom.xml
- lines 30-29
- jaxb-jakarta/pom.xml
- lines 32-33
- lines 54-56
- jaxb/pom.xml
- lines 32-31
- lines 47-51
- jaxrs/pom.xml
- lines 32-31
- jaxrs2/pom.xml
- lines 32-31
- jaxrs3/pom.xml
- lines 34-33
- jaxrs4/pom.xml
- lines 34-33
- json/pom.xml
- lines 32-31
- kotlin/pom.xml
- lines 34-33
- micrometer/pom.xml
- lines 30-29
- mock/pom.xml
- lines 32-31
- moshi/pom.xml
- lines 32-31
- okhttp/pom.xml
- lines 32-31
- pom.xml
- lines 537-538
- reactive/pom.xml
- lines 31-30
- ribbon/pom.xml
- lines 32-31
- sax/pom.xml
- lines 32-31
- slf4j/pom.xml
- lines 32-31
- soap-jakarta/pom.xml
- lines 32-33
- lines 63-62
- lines 79-81
- soap/pom.xml
- lines 32-31
- lines 55-60
- lines 70-71
- spring/pom.xml
- lines 34-33
- spring4/pom.xml
- lines 32-31
kdavisk6
approved these changes
Sep 14, 2024
kdavisk6
added
the
ready to merge
Member
|
These changes are approved. We'll leave this PR open for a few more days to allow for additional feedback. If there is none, we'll merge this. Thanks again for your help! |
kdavisk6
added
the
waiting for feedback
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes #2540 Co-authored-by: Jakub Venglar <venglar@rixo.cz>
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes #2540 Co-authored-by: Jakub Venglar <venglar@rixo.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases.
These content types are all valid and results in utf-8: text/html;charset=utf-8
text/html;charset=UTF-8
Text/HTML;Charset="utf-8"
text/html; charset="utf-8"
Fixes #2540