Repository navigation
Fix regex support when there are multiple @Path regexes - #242
Merged
codefromthecrypt merged 1 commit intoJun 12, 2015
Merged
Conversation
|
NetflixOSS » feign » feign-pull-requests #121 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jun 12, 2015
Fix regex support when there are multiple @path regexes
|
thanks for the quick turnaround, pushing 8.4.1 shortly! |
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fix regex support when there are multiple @path regexes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My last PR had a bug in it when dealing with multiple path params that have regexes in them. This PR fixes that, and also finishes off implementing the jax-rs spec here https://jax-rs-spec.java.net/nonav/2.0/apidocs/javax/ws/rs/Path.html by stripping spaces before and after a param name.