Skip to content

Fix regex support when there are multiple @Path regexes - #242

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
jacob-meacham:bugfix/multiple-regexes
Jun 12, 2015
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
jacob-meacham:bugfix/multiple-regexes

Conversation

@jacob-meacham

Copy link
Copy Markdown
Contributor

My last PR had a bug in it when dealing with multiple path params that have regexes in them. This PR fixes that, and also finishes off implementing the jax-rs spec here https://jax-rs-spec.java.net/nonav/2.0/apidocs/javax/ws/rs/Path.html by stripping spaces before and after a param name.

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #121 SUCCESS
This pull request looks good

@codefromthecrypt codefromthecrypt added this to the 8.4.1 milestone Jun 12, 2015
codefromthecrypt pushed a commit that referenced this pull request Jun 12, 2015
Fix regex support when there are multiple @path regexes
@codefromthecrypt
codefromthecrypt merged commit 44459da into OpenFeign:master Jun 12, 2015
@codefromthecrypt

Copy link
Copy Markdown

thanks for the quick turnaround, pushing 8.4.1 shortly!

@jacob-meacham
jacob-meacham deleted the bugfix/multiple-regexes branch October 23, 2015 20:19
velo pushed a commit that referenced this pull request Oct 8, 2024
Fix regex support when there are multiple @path regexes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants