Skip to content

Correct time decoding in RetryAfterDecoder - #224

Merged
codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
jnaous:fix-retry-after-decoder
Apr 24, 2015
Merged

codefromthecrypt merged 1 commit into
OpenFeign:masterfrom
jnaous:fix-retry-after-decoder

Conversation

@jnaous

@jnaous jnaous commented Apr 24, 2015

Copy link
Copy Markdown

currentTimeNanos was not returning nanos.

currentTimeNanos was not returning nanos.
@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #96 SUCCESS
This pull request looks good

@codefromthecrypt

Copy link
Copy Markdown

holy moly.. that was quite a bug! thanks for the fix!

codefromthecrypt pushed a commit that referenced this pull request Apr 24, 2015
Correct time decoding in RetryAfterDecoder
@codefromthecrypt
codefromthecrypt merged commit 362f5e6 into OpenFeign:master Apr 24, 2015
@codefromthecrypt

Copy link
Copy Markdown

lemme know if this needs to be rushed out as a subminor

@jnaous

jnaous commented Apr 24, 2015

Copy link
Copy Markdown
Author

Would be great if you can, we were looking into using that for retries, but stopped when we noticed the bug. Not yet urgent. When were you planning the next release?

@codefromthecrypt

codefromthecrypt commented Apr 24, 2015 via email

Copy link
Copy Markdown

@codefromthecrypt

codefromthecrypt commented Apr 24, 2015 via email

Copy link
Copy Markdown

velo pushed a commit that referenced this pull request Oct 8, 2024
Correct time decoding in RetryAfterDecoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants