Skip to content

Enforces source compatibility with animal-sniffer - #213

Merged
codefromthecrypt merged 1 commit into
masterfrom
adrian.source16-animalsniffer
Mar 18, 2015
Merged

codefromthecrypt merged 1 commit into
masterfrom
adrian.source16-animalsniffer

Conversation

@codefromthecrypt

Copy link
Copy Markdown

Before, finding source compatibility issues relied on building with an
old JDK. This uses animal-sniffer to enforce java language level 6.

@codefromthecrypt codefromthecrypt added this to the 8.2.0 milestone Mar 17, 2015
@codefromthecrypt

Copy link
Copy Markdown
Author

cc @rspieldenner

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #84 SUCCESS
This pull request looks good

@spencergibb

Copy link
Copy Markdown
Contributor

@adriancole I'm happy to see feign moving forward. I have an issue (spring-cloud/spring-cloud-netflix#183) to upgrade to 8.0.0 and 8.1.0 got released before I could get to it!

@codefromthecrypt

Copy link
Copy Markdown
Author

you need to thank @rspieldenner https://github.com/rspieldenner for that.
He's responsible for our new ability to do self-service releases.

@spencergibb

Copy link
Copy Markdown
Contributor

amen to that. Thanks @rspieldenner

@codefromthecrypt
codefromthecrypt force-pushed the adrian.source16-animalsniffer branch from 995e83d to 0ed8253 Compare March 18, 2015 03:41
Before, finding source compatibility issues relied on building with an
old JDK. This uses animal-sniffer to enforce java language level 6.
@codefromthecrypt

Copy link
Copy Markdown
Author

updated with more generalized approach, complements of our hero @rspieldenner

@cloudbees-pull-request-builder

Copy link
Copy Markdown

NetflixOSS » feign » feign-pull-requests #85 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Mar 18, 2015
Enforces source compatibility with animal-sniffer
@codefromthecrypt
codefromthecrypt merged commit ca068eb into master Mar 18, 2015
@codefromthecrypt
codefromthecrypt deleted the adrian.source16-animalsniffer branch March 18, 2015 14:57
velo pushed a commit that referenced this pull request Oct 8, 2024
Enforces source compatibility with animal-sniffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants