Polishes GitHub example#196
Merged
Merged
Conversation
The GitHub example could be better organized as top-down. Also, it is easier to show basic error decoding when there is less structure.
Author
|
cc @sfussenegger this just builds on what you did. I noticed the original example you added to could be structured a little better. |
Author
There was a problem hiding this comment.
I chose to take out this detail, as the example oversimplifies anyway. key story to tell is that we can use a decoder in the error decoder.
|
NetflixOSS » feign » feign-pull-requests #68 SUCCESS |
Contributor
|
ok, thanks for info |
codefromthecrypt
pushed a commit
that referenced
this pull request
Feb 25, 2015
Polishes GitHub example
Author
|
ok both are in 7.x too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub example could be better organized as top-down. Also, it is
easier to show basic error decoding when there is less structure.