Skip to content

update comment Retryer.java#1228

Merged
velo merged 1 commit into
OpenFeign:masterfrom
paladim:paladim-refactor-retryer-comment
May 19, 2020
Merged

update comment Retryer.java#1228
velo merged 1 commit into
OpenFeign:masterfrom
paladim:paladim-refactor-retryer-comment

Conversation

@paladim

@paladim paladim commented May 19, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@velo velo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@velo velo merged commit 1ffa9be into OpenFeign:master May 19, 2020
* (where 1.5 is the backoff factor), to the maximum interval.
*
* @return time in nanoseconds from now until the next attempt.
* @return time in milliseconds from now until the next attempt.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 just wasted 30 mins trying to understand why period would be in nanos and maxPeriod in millis 🤣

velo pushed a commit that referenced this pull request Oct 7, 2024
velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants