Skip to content

Maintain user-given order for header values - #1009

Merged
kdavisk6 merged 1 commit into
OpenFeign:masterfrom
mbarkley:bug/1007
Jul 22, 2019
Merged

kdavisk6 merged 1 commit into
OpenFeign:masterfrom
mbarkley:bug/1007

Conversation

@mbarkley

Copy link
Copy Markdown
Contributor

Fixes bug where HeaderTemplate stored values in a HashSet which
caused the following issues:

  • Header values could be written in wrong order
  • Order was not stable between JVM instances

Fixes #1007

Fixes bug where HeaderTemplate stored values in a HashSet which
caused the following issues:

* Header values could be written in wrong order
* Order was not stable between JVM instances

Fixes OpenFeign#1007
@kdavisk6 kdavisk6 self-assigned this Jul 18, 2019
@kdavisk6 kdavisk6 added the bug Unexpected or incorrect behavior label Jul 18, 2019

@kdavisk6 kdavisk6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbarkley

Thank you for such a quick turnaround. I've approved these changes and marked this PR as ready to merge. If there are no additional comments from other members in the next few days, I will merge this change.

@kdavisk6 kdavisk6 added the ready to merge Will be merged if no other member ask for changes label Jul 18, 2019
@kdavisk6 kdavisk6 removed their assignment Jul 18, 2019
@kdavisk6 kdavisk6 added this to the 10.2.4 milestone Jul 18, 2019
@kdavisk6
kdavisk6 merged commit aa565e4 into OpenFeign:master Jul 22, 2019
velo pushed a commit that referenced this pull request Oct 7, 2024
Fixes bug where HeaderTemplate stored values in a HashSet which
caused the following issues:

* Header values could be written in wrong order
* Order was not stable between JVM instances

Fixes #1007
velo pushed a commit that referenced this pull request Oct 8, 2024
Fixes bug where HeaderTemplate stored values in a HashSet which
caused the following issues:

* Header values could be written in wrong order
* Order was not stable between JVM instances

Fixes #1007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected or incorrect behavior ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HeaderTemplate has non-deterministic order for multi-valued headers

2 participants