Skip to content

Fixes 1003: Do not wrap exceptions in RuntimeException - #1004

Merged
kdavisk6 merged 1 commit into
OpenFeign:masterfrom
SimY4:master
Jul 18, 2019
Merged

kdavisk6 merged 1 commit into
OpenFeign:masterfrom
SimY4:master

Conversation

@SimY4

@SimY4 SimY4 commented Jul 8, 2019 •

Copy link
Copy Markdown
Contributor

Fixes #1003

Initially, the ReactiveInvocationHandler.java was wrapping method invocation in a Callable. That has a few drawbacks, one of which is the fact that we cannot propagate Throwable property and we need to wrap it in some new Exception class.
This PR wraps methodInvocation in a generic Publisher instead. Publisher allows us to signal Throwables back as an error signal and without additional wrapping.

@kdavisk6

kdavisk6 commented Jul 8, 2019

Copy link
Copy Markdown
Member

Thanks for this PR. I will review and provide feedback later today.

@kdavisk6 kdavisk6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimY4

Fantastic work. I appreciate the additional work put into the test cases. I've marked this PR as ready to merge. If there are no other comments from any other contributors in the next few days, I'll merge this PR.

@kdavisk6 kdavisk6 added the ready to merge Will be merged if no other member ask for changes label Jul 12, 2019
@kdavisk6 kdavisk6 added this to the 10.2.4 milestone Jul 18, 2019
@kdavisk6
kdavisk6 merged commit a2904ad into OpenFeign:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reactive wrappers for feighn wraps everything in RuntimeException

2 participants