-
Notifications
You must be signed in to change notification settings - Fork 286
Etape 3 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KentinTL
wants to merge
13
commits into
OpenClassrooms-Student-Center:master
Choose a base branch
from
KentinTL:etape-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Etape 3 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er with local variables
…ll 2 time logic into he mehtod
…method Simplify stream.filter...count == 0 into noneMatch method Modify privates List VisitedLocation and UserReward into copyOnWriteArrayList Simplify addUserReward because always return true
etape-2 doned
…easely withtout implement to much logic into the conroller class
…ing to much code into the new method getNearByAttractionDtos (TourGuideService)
…tions Add new getNearByAttractionDtos method to use it into TourGuideController where it returns the five closest attraction from user
…ce.getNearByAttractionDtos and return a complete object NearAttractionDto
Author
|
Review ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Etape 3 can be clotured
TODO from TourGuideController is doned and implemented logic to make it work is ok