Support allOf schemas referring to oneOf schemas#318
Support allOf schemas referring to oneOf schemas#318joschi merged 7 commits intoOpenAPITools:masterfrom
Conversation
|
I have pushed a minimal set of changes that fix my issue. I am not 100% this is the right way to solve the problem, though, any advice is welcome! |
|
May I interest some reviewers in reviewing this PR? |
|
Hi @julienrf ! Appreciate your effort while contributing to the project. I reviewed the code and left one comment. Should you have any questions to the comment, please let me know :) Thank you! |
core/src/main/java/org/openapitools/openapidiff/core/compare/SchemaDiff.java
Show resolved
Hide resolved
|
Thank you @timur27 for the review and improved solution! I’ve just pushed a commit that follows your suggestion. |
|
Hey @timur27, may I request another review? |
|
Hi @timur27, |
|
Friendly reminder: it would be great if I could get a review :) |
|
Could anyone help us move this PR forward? Maybe @joschi (forgive me the direct ping please :) ) |
Fixes #317