Skip to content

Conversation

@ditiwari-0512
Copy link
Contributor

Use MSAL to retrieve app+user auth token for PJO

Use MSAL to retrieve app+user auth token for PJO
@ditiwari-0512 ditiwari-0512 marked this pull request as draft October 8, 2021 10:52
@ditiwari-0512
Copy link
Contributor Author

@soocho-MSFT This is a draft review. Testing is in progress. Please take a look.

@soocho-MSFT
Copy link
Contributor

would you update readme.md. too?

@ditiwari-0512 ditiwari-0512 marked this pull request as ready for review October 18, 2021 10:37
Copy link
Contributor

@soocho-MSFT soocho-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ditiwari-0512 ditiwari-0512 reopened this Oct 19, 2021
@ditiwari-0512 ditiwari-0512 marked this pull request as draft October 19, 2021 12:55
@ditiwari-0512 ditiwari-0512 marked this pull request as ready for review October 19, 2021 12:57
@ditiwari-0512
Copy link
Contributor Author

@soocho-MSFT Can you please help merge the PR as I do not have write access to the repo.

@soocho-MSFT
Copy link
Contributor

@soocho-MSFT Can you please help merge the PR as I do not have write access to the repo.
Would you try again?

handle etag to avoid 412 http error
@ditiwari-0512
Copy link
Contributor Author

@soocho-MSFT Please re-review the last update

@soocho-MSFT
Copy link
Contributor

@ditiwari-0512 looks good to me.

@soocho-MSFT soocho-MSFT merged commit 290a065 into OfficeDev:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants