Added more useful error message when failing to load plugin on Windows. - #19
Merged
Conversation
rpavlik
force-pushed
the
win-error-message
branch
from
July 13, 2018 22:09
b335a02 to
921cb80
Compare
Member
|
This has been rebased to fix CI - if the CI passes, approved to merge. (Then let's release a version of this so I can package it for debian.) |
Contributor
Author
|
IIRC, this didn't provide any extra info in the particular case I was troubleshooting at the time, but it seemed like it might be helpful with future troubleshooting. |
rpavlik
approved these changes
Jul 13, 2018
rpavlik
left a comment
rpavlik
left a comment
Member
There was a problem hiding this comment.
Sounds just fine to me. Good to not throw out/ignore error codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.