[18.0][OU-ADD] website_sale_collect: Migration scripts. Renamed from website_sale_picking#5349
Conversation
|
/ocabot migration website_sale_collect |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Have you checked if there's anything of noupdate data due to the module renaming? Not sure if the system handles this case.
Yes, I checked, the records have V18 So I think that, for the analysis, these are completely different records. But since I consider them to be the same records, to prevent Odoo from creating new ones, I call Should I manually add these changes into a |
carlos-lopez-tecnativa
force-pushed
the
18.0-ou-add-website_sale_collect
branch
2 times, most recently
from
a485faf to
d36513c
Compare
| "website_sale_collect", | ||
| [ | ||
| "carrier_pick_up_in_store", | ||
| "payment_provider_on_site", |
There was a problem hiding this comment.
I don't see this one in noupdate_changes.xml
There was a problem hiding this comment.
Since the record does not have the noupdate attribute, I did not add it to noupdate_changes_work.xml.
I renamed the XML-ID to prevent Odoo from creating another payment.provider.
I also used delete_record_translations because the name field is translatable.
Or is this step not necessary for payment.provider?
V17
https://github.com/odoo/odoo/blob/7c3d34f5ef4d111fbbc89a07e207fe5add4d0275/addons/website_sale_picking/data/payment_provider_data.xml#L4
V18
https://github.com/odoo/odoo/blob/08b2573f2ac2b812a0e7f8ebaf90db431124ac69/addons/website_sale_collect/data/payment_provider_data.xml#L4
There was a problem hiding this comment.
If I don’t use delete_record_translations, the payment.provider keeps the old name.
I tested it, so I think it is necessary.
There was a problem hiding this comment.
That may be because you didn't load translations after the upgrade, but if it's noupdate=0, it shouldn't be a problem.
carlos-lopez-tecnativa
force-pushed
the
18.0-ou-add-website_sale_collect
branch
from
d36513c to
203567f
Compare
3 participants
TT57380
@Tecnativa @pedrobaeza @MiquelRForgeFlow could you please review this?