Skip to content

[18.0][OU-ADD] sale_margin: Nothing to do#5233

Merged
MiquelRForgeFlow merged 1 commit into
OCA:18.0from
Tecnativa:18.0-mig-sale_margin
Jul 30, 2025
Merged

[18.0][OU-ADD] sale_margin: Nothing to do#5233
MiquelRForgeFlow merged 1 commit into
OCA:18.0from
Tecnativa:18.0-mig-sale_margin

Conversation

@carlos-lopez-tecnativa

Copy link
Copy Markdown
Contributor

TT54275
@Tecnativa @pedrobaeza @MiquelRForgeFlow could you please review this?

@legalsylvain

Copy link
Copy Markdown
Contributor

/ocabot migration sale_margin

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to create update_analysis_work.

@carlos-lopez-tecnativa

carlos-lopez-tecnativa commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

You have to create update_analysis_work.

Why?
I understand that this file needs to be created when it has content
for example: #5236

But I don't see the need to create an empty file.
In other PRs, this was not required and the PR continued through to merge
for example: #4981

Could you clarify, please?

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

In other PRs, this was not required and the PR continued through to merge
for example: #4981

There wasn't a mass_mailing_slides folder in that case. If folder exists (and update_analysis.txt file exists) then work file has to be done. I know it's a bit of time wasting, but that's how @pedrobaeza likes it hehe

@pedrobaeza

Copy link
Copy Markdown
Member

Yes, if there's an update_analysis.txt file, a work file should be done.

@carlos-lopez-tecnativa

Copy link
Copy Markdown
Contributor Author

OK, thanks to both for clarifying this. I have created the file.

@MiquelRForgeFlow MiquelRForgeFlow merged commit 6b2674b into OCA:18.0 Jul 30, 2025
4 checks passed
@carlos-lopez-tecnativa carlos-lopez-tecnativa deleted the 18.0-mig-sale_margin branch July 30, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants