[18.0][OU-ADD] project#5203
Merged
Merged
Conversation
Contributor
Author
|
/ocabot migration project |
pedrobaeza
reviewed
Jul 29, 2025
| rule = env.ref( | ||
| "project_todo.task_visibility_rule_project_user", raise_if_not_found=False | ||
| ) | ||
| if rule: |
Member
There was a problem hiding this comment.
@MiquelRForgeFlow you don't need to do this check, as simply calling the rename method will perform the same: if it doesn't exist, nothing happens.
Contributor
Author
Member
There was a problem hiding this comment.
It's a info one, so no problem, and it's done this way across whole OpenUpgrade.
| new model project.share.collaborator.wizard [transient] | ||
| ---Fields in module 'project'--- | ||
| project / project.collaborator / limited_access (boolean) : NEW hasdefault: default | ||
| # NOTHING TO DO |
Member
There was a problem hiding this comment.
Please put why is nothing to do.
Contributor
Author
There was a problem hiding this comment.
boolean with default False
Member
There was a problem hiding this comment.
But please put it on the work file for other times, as stated several times. We don't know from this file which is the default and why it's correct to let it that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Supersedes #5036.