Skip to content

[18.0][OU-ADD] project#5203

Merged
MiquelRForgeFlow merged 3 commits into
OCA:18.0from
ForgeFlow:18.0-mig-project
Jul 28, 2025
Merged

[18.0][OU-ADD] project#5203
MiquelRForgeFlow merged 3 commits into
OCA:18.0from
ForgeFlow:18.0-mig-project

Conversation

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

Supersedes #5036.

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor Author

/ocabot migration project

@MiquelRForgeFlow MiquelRForgeFlow merged commit 68c2e64 into OCA:18.0 Jul 28, 2025
4 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-mig-project branch July 28, 2025 12:14
rule = env.ref(
"project_todo.task_visibility_rule_project_user", raise_if_not_found=False
)
if rule:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelRForgeFlow you don't need to do this check, as simply calling the rename method will perform the same: if it doesn't exist, nothing happens.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to avoid this log: Selection_4853

I mean, if somebody doesn't have project_todo and see this log, they may wrongly worry why it's missing an xmlid.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a info one, so no problem, and it's done this way across whole OpenUpgrade.

new model project.share.collaborator.wizard [transient]
---Fields in module 'project'---
project / project.collaborator / limited_access (boolean) : NEW hasdefault: default
# NOTHING TO DO

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put why is nothing to do.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean with default False

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please put it on the work file for other times, as stated several times. We don't know from this file which is the default and why it's correct to let it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants